Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Update SRep hash to fix windows build #298

Merged
merged 1 commit into from
May 5, 2023
Merged

COMP: Update SRep hash to fix windows build #298

merged 1 commit into from
May 5, 2023

Conversation

HarryDC
Copy link
Contributor

@HarryDC HarryDC commented May 5, 2023

No description provided.

@HarryDC HarryDC requested a review from vicory May 5, 2023 13:46
@vicory vicory merged commit 730f124 into master May 5, 2023
@jcfr
Copy link
Member

jcfr commented May 5, 2023

Thanks for updating the version of SRep 🙏

Moving forward make sure to reference the changes being integrated by the update, it has few purposes:

  • streamline the review process
  • allow to easily understand the scope of the change

For an example of commit, see 59fbb27

@jcfr jcfr deleted the fix-windows-build branch May 5, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicory vicory vicory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarryDC @jcfr @vicory