Bug fix incorrect paging & end of results detection #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you ! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in paging and end-of-results detection when downloading images from Bing. The changes update the paging parameters by using a hard-coded page size multiplier and add a check to break out of the loop when no new images are found.
- Update paging calculation to multiply the page counter by a hard-coded page size.
- Replace the previous '&first' and '&count' parameters with updated values based on the page size.
- Introduce a flag to detect when no new images are found and break out of the loop.
| found_image = True | ||
|
|
||
| if not found_image: | ||
| logging.info("[%] No more images are available") |
There was a problem hiding this comment.
The log message uses '[%]' which appears to be a formatting placeholder that is not being replaced; consider updating it to include meaningful context or removing the placeholder.
Suggested change
| logging.info("[%] No more images are available") | |
| logging.info("No more images are available") |
Copilot uses AI. Check for mistakes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&first= query param is not the page count but the image count, so sending the pageCount is only incrementing by 1 image and getting identical results to the last query except 1 new image.
html == "" is not a reliable way to check for end of results because bing will just keep returning the last page of images if there are no more images available