Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten run method signature to avoid stack overflows. #204

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

maleadt
Copy link
Collaborator

@maleadt maleadt commented Nov 24, 2022

Fixes #198

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.10%. Comparing base (a9983e9) to head (9ca3c64).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
src/activity/events.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   55.99%   56.10%   +0.11%     
==========================================
  Files          36       36              
  Lines         843      843              
==========================================
+ Hits          472      473       +1     
+ Misses        371      370       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 809994e into JuliaWeb:master Nov 24, 2022
@maleadt maleadt deleted the run branch November 24, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch-all run definition causes stack overflows
2 participants