Multi-Output helper function #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Did not go into details but the obvious edge case not considered here is if N == P |
st--
reviewed
Jul 28, 2021
st--
reviewed
Jul 28, 2021
Co-authored-by: st-- <st--@users.noreply.github.com>
st--
reviewed
Jul 28, 2021
st--
reviewed
Jul 28, 2021
There was a problem hiding this comment.
Generally looks good to me, but I think it'd be super helpful to include a concrete example with explicit numbers in the docstrings, as even being somewhat familiar with all this it keeps doing my head in. Do doctests count towards code coverage? It might make more sense to move the "consistency checks" to actual tests.
st--
reviewed
Jul 28, 2021
st--
reviewed
Jul 28, 2021
Co-authored-by: st-- <st--@users.noreply.github.com>
Co-authored-by: st-- <st--@users.noreply.github.com>
…ussianProcesses/KernelFunctions.jl into wct/multi-output-helpers
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
st--
reviewed
Jul 29, 2021
st--
reviewed
Jul 29, 2021
st--
reviewed
Jul 29, 2021
|
Just trying something now |
Co-authored-by: st-- <st--@users.noreply.github.com>
|
It works locally at least! |
st--
reviewed
Jul 29, 2021
Co-authored-by: st-- <st--@users.noreply.github.com>
st--
approved these changes
Jul 29, 2021
|
@theogf your regex magic seems to have sorted it. Have bumped patch -- will merge once CI passes. |
…ussianProcesses/KernelFunctions.jl into wct/multi-output-helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a function to make it possible to work with our input types for multi-output GPs more straightforwardly in the isotopic case.
It's entirely possible that we'll want more helper functions as we move forwards, so this should be seen as a first step in that direction, rather than something that will solve all useability problems.
edit: I've added a note to the docs. Unless I'm missing something obvious, we don't currently have a multi-output example, so I'm not going to create one in this PR to showcase this functionality.
edit2: also note that I'm testing only via doctests. It feels a bit weird, but it's not obviously to me that it's obviously a bad idea, so maybe it's okay?