enable multi-statement execute #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=========================================
Coverage ? 31.62%
=========================================
Files ? 8
Lines ? 449
Branches ? 0
=========================================
Hits ? 142
Misses ? 307
Partials ? 0
Continue to review full report at Codecov.
|
|
@quinnj Is there any interest in incorporating this feature? |
|
Yes, this looks great. Thanks @mcmcgrath13! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds while loop to MySQL.execute! to enable multi-statement execution. This functionality is already enabled via the client_flag, but is not working (see Issue 104).
This implements the solution from the MySQL C API docs, but assumes that only non-returning statements are being executed. This is consistent with the current implementation and the docs.