feat: allow periods in dataset names #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenpi
force-pushed
the
mp/dataset-names-period
branch
from
14a9927 to
1180cfb
Compare
pfitzseb
reviewed
Feb 4, 2025
mortenpi
force-pushed
the
mp/dataset-names-period
branch
from
ae0348a to
65c8453
Compare
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
mortenpi
force-pushed
the
mp/dataset-names-period
branch
from
65c8453 to
004b35b
Compare
pfitzseb
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation is to allow dataset names to have file extensions.
However, from a syntax/validation perspective, the rules for
.-s are same as for/-s, i.e. it functions as a kind of a path/segment separator. This allows us to easily rule data odd and potentially problematic dataset names like..,a---...andfoo...bar.