Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: handle symbolic links while comparing paths #72

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

tanmaykm
Copy link
Member

Update test to handle differences in paths that may crop up due to symbolic links. Compare paths by convertig both to realpaths.

Update test to handle differences in paths that may crop up due to symbolic links. Compare paths by convertig both to `realpath`s.
@mortenpi mortenpi changed the title fix: handle symbolic links while comparing paths test: handle symbolic links while comparing paths Jan 29, 2025
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanmaykm tanmaykm merged commit f8074f3 into master Jan 29, 2025
14 checks passed
@tanmaykm tanmaykm deleted the tan/symlinkfix branch January 29, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants