Storage driver for data embedded in Data.toml #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Blobs are stored as base64 encoded strings * Trees are stored as dictionaries While we're at it, start to clean up storage backend interface. Also deprecate `abspath(::RelPath)` depending on `pwd()`, as the assumption that this refers to the filesystem, and that depending on the global `pwd()` is actually reasonable seem pretty dubious in hindsight.
|
Very cool! @lungben @pankgeorg |
8 tasks
|
I thought about this too late, but you can think of base64-ecoded data as a special case of a URL! See JuliaLang/Downloads.jl#122 |
|
Sure, that's true! It's quite cool for tiny amounts of data. I guess it's a bit impractical for medium-size data such as could be embedded in the Data.toml without problems. Or tree-structured directory-like data which this PR implements. Do you think there's redundancy with this PR? To me they seem to be separate use cases with a little bit of overlap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're at it, start to clean up storage backend interface.
Also deprecate
abspath(::RelPath)depending onpwd(), as theassumption that this refers to the filesystem, and that depending on the
global
pwd()is actually reasonable seem pretty dubious in hindsight.CC @fonsp — here's a storage driver for base64 data embedded within the Data.toml!