Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JuliaComputing/DataSets.jl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.2
Choose a base ref
...
head repository: JuliaComputing/DataSets.jl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2.3
Choose a head ref
  • 10 commits
  • 12 files changed
  • 1 contributor

Commits on May 17, 2021

  1. Configuration menu
    Copy the full SHA
    9ec5ae5 View commit details
    Browse the repository at this point in the history
  2. Defer unscoped open() resource handling to finalization time

    The trick here is to root the resource context within the finalizer. It
    only works for mutable objects, or objects with mutable fields, where a
    finalizer can be attached by proxy. But that's already pretty good.
    c42f committed May 17, 2021
    Configuration menu
    Copy the full SHA
    7ac2700 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Make Blob and BlobTree mutable to allow finalizers

    Of course immutable struct can't be finalized, but also there's no way
    around this; despite initial apperances, _root_resource is semantically
    unsound in general. So just bite the bullet and make Blob and BlobTree
    mutable.
    
    Uses the new ResourceContexts.detach_context_cleanup to transform
    context-based resource handling into finalizer-based resource handling.
    c42f committed May 20, 2021
    Configuration menu
    Copy the full SHA
    857ed13 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Fix ResourceContexts version

    c42f committed May 28, 2021
    Configuration menu
    Copy the full SHA
    5727f82 View commit details
    Browse the repository at this point in the history
  2. Clarify docs surrounding open()

    Updated to be more explicit the role of the unscoped vs scoped forms of
    open.
    c42f committed May 28, 2021
    Configuration menu
    Copy the full SHA
    fa8d51b View commit details
    Browse the repository at this point in the history
  3. Merge pull request #12 from JuliaComputing/cjf/context-resource-handling

    Use ResourceContexts.jl for resource handling
    c42f authored May 28, 2021
    Configuration menu
    Copy the full SHA
    2dd797b View commit details
    Browse the repository at this point in the history

Commits on May 29, 2021

  1. Bump version to 0.2.3

    c42f committed May 29, 2021
    Configuration menu
    Copy the full SHA
    d78528e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Storage driver for data embedded in Data.toml (#15)

    * Storage driver for data embedded in Data.toml
    
    * Blobs are stored as base64 encoded strings
    * Trees are stored as dictionaries
    
    While we're at it, start to clean up storage backend interface.
    
    Also deprecate `abspath(::RelPath)` depending on `pwd()`, as the
    assumption that this refers to the filesystem, and that depending on the
    global `pwd()` is actually reasonable seem pretty dubious in hindsight.
    c42f authored Jun 1, 2021
    Configuration menu
    Copy the full SHA
    20bd7e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    22257e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Bugfix for storage backend compatibility, plus tests (#18)

    * Fix for storage backends which don't use ResourceContexts
    
    * Compatibility tests for old backend API
    c42f authored Jun 4, 2021
    2 Configuration menu
    Copy the full SHA
    8e07c35 View commit details
    Browse the repository at this point in the history
Loading