Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tokenizer #3061

Merged
merged 8 commits into from
Jan 27, 2025
Merged

Update tokenizer #3061

merged 8 commits into from
Jan 27, 2025

Conversation

lvhan028
Copy link
Collaborator

  1. remove never used tokenizer "SentencePieceTokenizer"
  2. Let async_engine instead of inference engines init tokenizer
  3. converter places the tokenizer-related files under the root directory of workspace rather than the weight directory

@AllentDan
Copy link
Collaborator

Unit tests failed.

@lvhan028 lvhan028 requested a review from grimoire January 21, 2025 13:58
AllentDan
AllentDan reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean our convert.py should deprecate meta_llama models?

@lvhan028
Copy link
Collaborator Author

Does it mean our convert.py should deprecate meta_llama models?

Yes, you are right

AllentDan
AllentDan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 26622b8 into InternLM:main Jan 27, 2025
5 checks passed
tastelikefeet added a commit to tastelikefeet/lmdeploy that referenced this pull request Feb 17, 2025
@tastelikefeet
Merge branch 'main' into feat/reload_state_dict
0c6b188 
* main: (90 commits)
  Fix cogvlm and phi3vision (InternLM#3137)
  support release pipeline (InternLM#3069)
  [ci] fix some fail in daily testcase (InternLM#3134)
  Fix internvl2.5 error after eviction (InternLM#3122)
  fix UT of deepseek chat template (InternLM#3125)
  Update benchmark script and user guide (InternLM#3110)
  bump version to v0.7.0.post3 (InternLM#3115)
  fix postional argument (InternLM#3086)
  remove logitswarper (InternLM#3109)
  [Fix] fix the URL judgment problem in Windows (InternLM#3103)
  fix user guide about cogvlm deployment (InternLM#3088)
  add option max-concurrent-requests for api_server(InternLM#2961)
  bump version to v0.7.0.post2 (InternLM#3094)
  Fix xcomposer2d5 (InternLM#3087)
  Add system role to deepseek chat template (InternLM#3031)
  Update tokenizer (InternLM#3061)
  Add deepseek-r1 chat template (InternLM#3072)
  bump version to v0.7.0.post1 (InternLM#3076)
  More arguments in api_client, update docstrings (InternLM#3077)
  fix sliding window mgr (InternLM#3068)
  ...

# Conflicts:
#	lmdeploy/turbomind/turbomind.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irexyc irexyc irexyc left review comments

@grimoire grimoire grimoire approved these changes

@lzhangzz lzhangzz lzhangzz approved these changes

@AllentDan AllentDan AllentDan approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lvhan028 @AllentDan @grimoire @irexyc @lzhangzz