Skip to content

[MOB-12511] Replace JaCoCo’s enabled with required #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asamiz merged 3 commits into from
Jul 5, 2023
Merged

[MOB-12511] Replace JaCoCo’s enabled with required #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3dc77d6
fix(jacoco-reports): replace enabled prop with required for html and …
asamiz Jul 3, 2023
944143b
fix(jacoco-reports): fix PR comments
asamiz Jul 3, 2023
d2397dc
chore(jacoco-reporting): add changes to CHANGELOG
asamiz Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixed

- Fix an issue with the Android sourcemaps upload Gradle task getting recreated when both `bundleReleaseJsAndAssets` and `createBundleReleaseJsAndAssets` tasks exist in the same Android project ([#991](https://github.com/Instabug/Instabug-React-Native/pull/991)), closes [#989](https://github.com/Instabug/Instabug-React-Native/issues/989).
- Fix an issue with JaCoCo gradle plugin replacing the `enabled` method with `required` prop to prevent gradle scripts breaking on version `0.72` ([#995](https://github.com/Instabug/Instabug-React-Native/pull/995)), closes [#994](https://github.com/Instabug/Instabug-React-Native/issues/994).

## [11.12.0](https://github.com/Instabug/Instabug-React-Native/compare/v11.10.0...11.12.0) (May 30, 2023)

Expand Down
4 changes: 2 additions & 2 deletions android/jacoco.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ task jacocoTestReport(type: JacocoReport) {
dependsOn 'testDebugUnitTest'

reports {
html.enabled true
xml.enabled true
html.required = true
xml.required = true
}

def excludes = [
Expand Down