Skip to content

[MOB-12473] Skip Recreating Sourcemaps Gradle Task If It Exists #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a7medev merged 3 commits into from
Jun 21, 2023
Merged

[MOB-12473] Skip Recreating Sourcemaps Gradle Task If It Exists #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f09be10
Skip recreating sourcemaps task if it exists
a7medev Jun 12, 2023
1ebbcec
Update Changelog
a7medev Jun 12, 2023
c1154ed
Fix typos
a7medev Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## [Unreleased](https://github.com/Instabug/Instabug-React-Native/compare/v11.12.0...dev)

### Fixed

- Fix an issue with the Android sourcemaps upload Gradle task getting recreated when both `bundleReleaseJsAndAssets` and `createBundleReleaseJsAndAssets` tasks exist in the same Android project ([#991](https://github.com/Instabug/Instabug-React-Native/pull/991)), closes [#989](https://github.com/Instabug/Instabug-React-Native/issues/989).

## [11.12.0](https://github.com/Instabug/Instabug-React-Native/compare/v11.10.0...11.12.0) (May 30, 2023)

### Changed
Expand Down
9 changes: 9 additions & 0 deletions android/sourcemaps.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ gradle.projectsEvaluated {

Task createUploadSourcemapsTask(String flavor) {
def name = 'uploadSourcemaps' + flavor.capitalize()

// Don't recreate the task if it already exists.
// This prevents the build from failing in an edge case where the user has
// both `bundleReleaseJsAndAssets` and `createBundleReleaseJsAndAssets`
def taskExists = tasks.getNames().contains(name)
if (taskExists) {
return tasks.named(name).get()
}

def provider = tasks.register(name) {
group 'instabug'
description 'Uploads sourcemaps file to Instabug server'
Expand Down