refactor: move feature flags from APM to core #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…APM-method-to-Core
kholood-ea
approved these changes
Aug 1, 2024
a7medev
changed the title
a7medev
requested changes
Aug 1, 2024
Contributor
a7medev
left a comment
a7medev
left a comment
There was a problem hiding this comment.
Good job @ahmedAlaaInstabug 👏🏼
I just have a slight comment so let me know your thoughts 🙏🏼
a7medev
requested changes
Aug 2, 2024
android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java
Outdated
Show resolved
Hide resolved
Collaborator
Coverage Report
|
a7medev
reviewed
Sep 12, 2024
Comment on lines
+584
to
+588
| /** | ||
| * Sets listener to W3ExternalTraceID flag changes | ||
| * @param handler A callback that gets the update value of the flag | ||
| */ | ||
| export const _registerW3CFlagsChangeListener = ( |
Contributor
There was a problem hiding this comment.
Let's annotate this with @internal. We can also add the stripInternal TSConfig flag as true to strip @internal functions like this from the type definitions, what do you think?
Suggested change
| /** | |
| * Sets listener to W3ExternalTraceID flag changes | |
| * @param handler A callback that gets the update value of the flag | |
| */ | |
| export const _registerW3CFlagsChangeListener = ( | |
| /** | |
| * Sets listener to W3ExternalTraceID flag changes | |
| * @param handler A callback that gets the update value of the flag | |
| * @internal | |
| */ | |
| export const _registerW3CFlagsChangeListener = ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
JIRA ID : MOB-14801
Checklists
Development
Code review