Android SDL opengles2 implementation #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

leonelhs wants to merge 9 commits into Immediate-Mode-UI:master from leonelhs:master

leonelhs commented Feb 21, 2022

Hello friends!
I have written a Nuklear Android demo based on SDL opengles2.
this PR has zero modifications to the main core. It just contain a new demo source code.

I would like to share this demo with other devs in order to get feedbacks and keep improving mobile implementations.

My congratulations for this awesome project.


          Android SDL opengles2 implementation

f946c0d

Member

dumblob commented Feb 21, 2022 •

edited

Loading

I totally want to merge this PR! Thanks for the effort!

I'm now contemplating the following:

The PR is huge because of a lot of generated files. I think we should definitely provide a way (a simple script in shell/Python/... or in the worst case a maximally detailed TODO.md file) describing how to generate the files instead of providing the generated files themself.
In addition to (1), should we also provide some of the pre-generated files in case the script from (1) stops working (an evergreen when it comes to programming for Android), so that one still has at least something to quickly start with (before someone corrects the script in this repo)?

What do people programming for recent Android think about this?

And what do others think?


          Implementing build script in order get small demos

8fcd2a4

Author

leonelhs commented Feb 22, 2022 •

edited

Loading

I made an script to build the demos, SDL sources are symbolic links into the projects. Anyways you most have a SDL sources copy.

I think this project has to much potential, specially for game devs, its hard to write a decent UI from the scratch for mobile devices since you can’t mix platform widgets whit hardware surfaces.

All ready there is a lot of people looking at the SDL forums for info and how to implement Nuklear in his projects.
Actually SDL forums lead me to here.

dumblob reviewed

View reviewed changes

demo/android/sdl2surface_rawfb/build.sh Outdated

+              SOURCES=()
+              MKSOURCES=""
+              CURDIR=`pwd -P`

Member

dumblob Feb 24, 2022

`pwd -P` is dangerous here. I'd prefer "$( pwd -P )" instead 😉.

Author

leonelhs Feb 24, 2022

done 😉

dumblob reviewed

View reviewed changes

demo/android/sdl2surface_rawfb/build.sh Outdated

+                  exit 1
+              fi
+              if [ ! -d "$ANDROID_HOME/ndk-bundle" -a -z "$ANDROID_NDK_HOME" ]; then

Member

dumblob Feb 24, 2022

Should be if [ ! -d "$ANDROID_HOME/ndk-bundle" ] && [ -z "$ANDROID_NDK_HOME" ]; then as more than one comparison will never be supported according to the latest POSIX (yes, we're in bash here, but while I'm at nitpicking... 😉).

Author

leonelhs Feb 24, 2022

done 😉

dumblob reviewed

View reviewed changes

demo/android/sdl2surface_rawfb/build.sh


		# Start Building

		rm -rf $BUILDPATH

Member

dumblob Feb 24, 2022

-> "$BUILDPATH"

dumblob reviewed

View reviewed changes

demo/android/sdl2surface_rawfb/build.sh

+              # Start Building
+              rm -rf $BUILDPATH
+              mkdir -p $BUILDPATH

Member

dumblob Feb 24, 2022

Same goes here and in all the many following lines 😉.

dumblob reviewed

View reviewed changes

demo/android/sdl2surface_rawfb/build.sh

+              __EOF__
+              # Update project and build
+              cd $BUILDPATH

Member

dumblob Feb 24, 2022

...until here 😄.

Author

leonelhs Feb 24, 2022

Sorry I don’t understand ...until here😳, I hope the Readme.md can clarify how the script is working

dumblob reviewed

View reviewed changes

demo/android/sdl_opengl2/.idea/workspace.xml Outdated

		@@ -0,0 +1,350 @@
		<?xml version="1.0" encoding="UTF-8"?>

Member

dumblob Feb 24, 2022

Is this .idea/ folder needed at all?

Author

leonelhs Feb 24, 2022

no needed and deleted 😉

dumblob reviewed

View reviewed changes

demo/android/sdl_opengl2/build.sh

    
            @@ -0,0 +1,97 @@
          
              #!/bin/bash

Member

dumblob Feb 24, 2022

Same comments as for the script above apply also here 😄.

Member

dumblob commented Feb 24, 2022

I feel we're on the right path 😉.

Btw. could you also create e.g. demo/android/README.md with a detailed code snippet which would fetch the newest released version of https://github.com/libsdl-org/SDL/tree/main/android-project , rename it to project-template.new/, move all the needed stuff from the current project-template/ to the new one, then rename project-template/ to project-template.old/, then rename project-template.new/ to project-template/ and then finally remove project-template.old/?

leonelhs added 3 commits

February 24, 2022 17:14


          Adding some instructions to build

1524d2b


          estetical changes

23eab64

just some stetical changes to readme


          grammar changes

93ec90c

grammar changes

Member

dumblob commented Apr 11, 2022

Ok, I've taken another look and gave a thought to it. I think we need the following and then I will merge this cool PR!

remove SDL sources from this PR altogether
if the SDL sources in this PR are patched by you, then provide only the patches and a makefile or at least a detailed description how to apply them

Let me know if there are any obstackles.

I would also like to apologize for commenting on the build.sh script - I've compared it to the SDL upstream's androidbuild.sh and almost fell over as they don't use "" around variables etc. But because it's much more important to stay as close to upstream as possible, I will not require these to be fixed in your PR to minimize the diff to the upstream file. I'll instead consider filing a bug in the SDL upstream tracker once I will recover from the fell over 😉.

leonelhs added 3 commits

April 21, 2022 17:22


          SDL sources removed

a070d07


          SDL sources removed

d549e80


          Readme updated

ddc7a40

Author

leonelhs commented Apr 21, 2022

SDL sources are removed 😁.
Feel free to comment or improve scripts.

dumblob mentioned this pull request

Please add an example for using nuklear-rust on Android snuk182/nuklear-rust#2

Open


          Merge branch 'Immediate-Mode-UI:master' into master

b7418c7

MaxGyver83 commented Nov 17, 2024

Great work! I know that it's old but both implementations still compile!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet