Skip to content

Conversation

dosumis
Copy link
Collaborator

@dosumis dosumis commented Jan 29, 2021

No description provided.

@dosumis dosumis requested review from matentzn and balhoff January 29, 2021 18:36
@dosumis
Copy link
Collaborator Author

dosumis commented Jan 29, 2021

Fixed using JPATH to enumerate MS text fields. (other changes are just tidying and updating travis tests).

Copy link
Member

@balhoff balhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would it be hard to also add logical_axioms (text inside each list item).

@dosumis
Copy link
Collaborator Author

dosumis commented Jan 29, 2021

Thanks! Would it be hard to also add logical_axioms (text inside each list item).

Not sure I follow. This covers the possible types of path for MS text fields:

logical_axioms.[*].text e.g. - example
equivalentTo|subClassOf|GCI|disjointWith.text - example

Am i missing something (besides that I should really have suite of tests - including tests for failure.)

@balhoff
Copy link
Member

balhoff commented Jan 29, 2021

Sorry, my mistake! I missed that line somehow. Looks good!

@dosumis dosumis merged commit cd126f9 into master Jan 29, 2021
@dosumis dosumis deleted the single_quote_test_MS_only branch January 29, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants