Skip to content

Conversation

AlioshaRabeshko
Copy link
Member

It's very difficult to write easy examples.

Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Branch name new-branch and PR title 'New branch' are not informative
  • It's a big PR (+256 lines) that's not ok
  • Remove package.json from PR

node_modules
*.log
.DS_Store
.package-lock.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add package-lock.json and package.json to .gitignore

@AlioshaRabeshko AlioshaRabeshko changed the title New branch Conditional Oct 1, 2017
@AlioshaRabeshko AlioshaRabeshko changed the title Conditional Conditions examples Oct 1, 2017
@AlioshaRabeshko AlioshaRabeshko deleted the new-branch branch October 1, 2017 15:56
@tshemsedinov
Copy link
Member

@AlioshaRabeshko what is a reason to close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants