Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt default container/routing files path to Symfony Flex #993

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Adopt default container/routing files path to Symfony Flex #993

merged 1 commit into from
Aug 7, 2017

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Aug 7, 2017

No description provided.

@Haehnchen Haehnchen merged commit 167170b into Haehnchen:master Aug 7, 2017
@Haehnchen
Copy link
Owner

thx related to #922

stof
stof reviewed Aug 31, 2017
View reviewed changes
src/fr/adrienbrault/idea/symfony2plugin/Settings.java
};

// Symfony 2 and 3 paths
public static String[] DEFAULT_ROUTES = new String[] {
"app/cache/dev/appDevUrlGenerator.php",
"var/cache/dev/appDevUrlGenerator.php",
"var/cache/dev/srcDevDebugProjectContainerUrlGenerator.php",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about DebugProjectContainer here ? This looks weird to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh, yees, seems to typo, will check later for real name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, probably srcDevUrlGenerator.php, as the only change is the kernel name (because of the kernel move from app to src)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, the comment before should say Symfony 2, 3 and 4 paths 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like path is right.

default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof even more, Symfony 3.3 has similar naming

default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, actually 2.7 has this change too symfony/symfony#20147

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, indeed. But then, it means you have to add more paths to account for them in other places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #1014

@aik099
Copy link

aik099 commented Sep 23, 2017

  1. Is this change released?
  2. How do I configure Symfony2 plugin to use Symfony Flex, because right now project created via Symfony Flex isn't detected by plugin as Symfony project?

cedricziel added a commit to cedricziel/idea-php-symfony2-plugin that referenced this pull request Aug 21, 2018
@cedricziel
Move fix for YamlServiceArgumentInspection out of awt event
cfa650a 
Fixes: Haehnchen#1037
Fixes: Haehnchen#993
Fixes: Haehnchen#1184
@cedricziel cedricziel mentioned this pull request Aug 21, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Koc @Haehnchen @aik099 @stof