Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] Add autocompletion and navigation for named arguments #2015

Closed
SVillette opened this issue Oct 5, 2022 · 2 comments
Closed
Labels

Comments

@SVillette
Copy link

Description

When using the translator service with a non default domain (e.g. "validators"), the autocompletion works when the domain is passed as the third argument but not when using PHP8 named arguments.

this->translator->trans('app.existing_translation', domain: 'validators') // Warning: "Symfony: Missing translation key"

In a global way, supporting autcompletion and navigation when using PHP named arguments would be a nice feature (as you started to support it for Symfony constraints classes).

Haehnchen added a commit that referenced this issue Oct 21, 2022
Haehnchen added a commit that referenced this issue Oct 21, 2022
…-trans

#2015 [Translation] Add inspection, autocompletion and navigation for named arguments
@Haehnchen
Copy link
Owner

added, translations are special cases because of 2 parameters id+domain. others are already behind an abtraction layer and will added also.

@SVillette
Copy link
Author

Thank you @Haehnchen

Haehnchen added a commit that referenced this issue Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants