Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Run/Debug Commands #1541

Open
Richard87 opened this issue Sep 24, 2020 · 9 comments
Open

Feature request: Run/Debug Commands #1541

Richard87 opened this issue Sep 24, 2020 · 9 comments
Labels

Comments

@Richard87
Copy link

Hi!

Thanks for an awesome plugin! It really saves me a lot of time every single day!

I would love a little green play button in the margin of commands, next to execute or the class...

Would that be easy to add / quick fix? maybe I could help?

@SergeC
Copy link

SergeC commented Dec 10, 2021

@Haehnchen Is any chance to have Run/Debug for Commands (same as for PHPUnit tests) in near future?

@Richard87
Copy link
Author

I wonder if it will be way easier to make now if its based on the newish #[AsCommand("app:command:name") attribute!

@Haehnchen Haehnchen self-assigned this May 4, 2022
@Haehnchen Haehnchen added fixed and removed todo labels May 7, 2022
@Haehnchen Haehnchen removed their assignment May 7, 2022
Haehnchen added a commit that referenced this issue May 7, 2022
#1541 provide linemarker to run Symfony command via internal console terminal
@ChristianVermeulen
Copy link

@Haehnchen While it is awesome we can run commands straight from phpstorm, it's not ideal the way it is implemented right now. We work with docker containers and currently there is no way to configure the plugin to run the command inside a container, so for us the feature is not really useful at the moment.

However, it is in the way of easily clicking through to the configuration of the command. As you can see, the linemarker now replaces the cog for configuration.
Screenshot 2022-05-12 at 10 28 04
Screenshot 2022-05-12 at 10 28 15

Can we perhaps move it to to the $defaulName-line so we can support both?

@ChristianVermeulen
Copy link

My bad, turns out this specific command was not yet configured 🙈.

Screenshot 2022-05-12 at 10 44 42
tenor-47887959

@Richard87
Copy link
Author

Awesome! Thanks @Haehnchen !

Is it possible to also look for the Attribute #[AsCommand('app:test')] instead of $defaultName?

@Richard87
Copy link
Author

Richard87 commented May 12, 2022

Skjermbilde 2022-05-12 kl  12 05 06
Skjermbilde 2022-05-12 kl  12 09 36

I see you have added a codeblock for it (https://github.com/Haehnchen/idea-php-symfony2-plugin/pull/1920/files#diff-bd1d67aad9012c45bcb6b02f252d9f007cf79ae6b13cf0f5bbbb643df1b41569R73) but it doesnt seem to work...

I'm running Symfony plugin 2022.1.225, and PHPStorm 2022.1 :)

Thanks for the amazing work, and is there anything I can do to help?

@Haehnchen
Copy link
Owner

thank you for this hint. i was thinking that the named arguments automatically were resolved by PhpAttribute, but its likely not the case.
name: 'app:test:test' should work.

i will fix this in the next release.

@Haehnchen
Copy link
Owner

@ChristianVermeulen yes, i was playing also with remote interpreter support like docker, but then stripped the first iteration, as this needed some improvements first, but will be added.

Haehnchen added a commit that referenced this issue May 13, 2022
#1541 fix supporting "asCommand" name as default value
@Richard87
Copy link
Author

Yup, can confirm: name: 'app:test:test' works great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants