Skip to content

commit changes for Issue #1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2017
Merged

commit changes for Issue #1 #2

merged 2 commits into from
Dec 5, 2017

Conversation

kelvinwijaya
Copy link
Contributor

Enhancement on ApiList sorting is not based on key first then value

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 74.564% when pulling 82d55bd on developement into 679a94f on master.

@kelvinwijaya
Copy link
Contributor Author

kelvinwijaya commented Dec 4, 2017 •
edited
Loading

Hi Robin, please review the pull request and merge the development branch to production

@robincher
Copy link
Contributor

@kelvinwijaya

Can update the version snapshot to 1.1 ?

Update the following files to 1.1

  1. CHANGELOG.md
  2. build.gradle
  3. pom.xml

@kelvinwijaya kelvinwijaya reopened this Dec 4, 2017
@kelvinwijaya
Copy link
Contributor Author

Version to minor release : 1.0.1

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 74.564% when pulling a5a1dcc on developement into 679a94f on master.

robincher
robincher approved these changes Dec 5, 2017
View reviewed changes
Copy link
Contributor

@robincher robincher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merging to master. Please proceed.

@kelvinwijaya kelvinwijaya merged commit 447c39d into master Dec 5, 2017
@robincher robincher deleted the developement branch December 11, 2017 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@robincher robincher robincher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kelvinwijaya kelvinwijaya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kelvinwijaya @coveralls @robincher