-
Notifications
You must be signed in to change notification settings - Fork 1
Fix matrix concat order in polyfill #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7864239 to
de77dba
Compare
e0baaf2 to
9095f21
Compare
|
Can u take a look at this test project and the unit tests in there.
It compares the 2 implementations with the original Apple's CoreGraphics one. and it seems like the new logic is failing? |
9095f21 to
17a11e3
Compare
|
Had removed that comment from the wrong file - sorted now. |
@khoi are you sure the tests are right? Why do any of them check for a delta bigger than the tolerance given the use of |
17a11e3 to
886701b
Compare
|
oops, you're right. Verified the changes and it looks correct now. Thanks for fixing |
The matrix concat operation was doing
B . AforA.concatenating(B)which was causing issues when combining transformations.