PHP 8.4 compatibility #822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@GrahamCampbell do you think you'll have a chance to review this or should we fork this library if we need PHP 8.4 support? |
Contributor
|
Any updates on this one? We're currently running into issues as well after a PHP upgrade and we'de rather not have to fork. |
|
I tested out this PR using a composer patch and it works for me nicely. It would be great if it could be merged! |
Member
|
Thanks for the PR. Version 12.0 will provide PHP 8.4 compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GrahamCampbell would you mind reviewing this?