Skip to content

Conversation

@zluiten
Copy link

@zluiten zluiten commented Jan 12, 2024

Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started. I've left a note inline to be addressed. I know existing code is not always with this doc, but net new code needs it.

*
* @return mixed
*/
public function commitMergeRequests($project_id, string $sha, array $parameters = [])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need param documentation and validation for the supported parameters please.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the "parameters" parameter as this api endpoint does not seem to support any parameters.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamCampbell GrahamCampbell changed the title Add support for listing merge requests associated with a commit [11.15] Add support for listing merge requests associated with a commit Mar 17, 2024
@GrahamCampbell GrahamCampbell changed the base branch from 11.13 to 11.15 March 17, 2024 21:39
@zluiten zluiten force-pushed the feature-add-support-for-commit-merge-requests branch from e0dc93d to 139f663 Compare April 25, 2024 08:58
@stale
Copy link

stale bot commented Jan 21, 2025

This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 21, 2025
@zluiten
Copy link
Author

zluiten commented Feb 13, 2025

This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions.

Don't close

@stale stale bot removed the stale label Feb 13, 2025
@GrahamCampbell GrahamCampbell deleted the branch GitLabPHP:11.15 February 23, 2025 16:56
@zluiten
Copy link
Author

zluiten commented Feb 24, 2025

@GrahamCampbell what's up with the closing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants