Skip to content

Specify project hook types #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2014
Merged

Specify project hook types #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions lib/Gitlab/Api/Projects.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,35 @@ public function hook($project_id, $hook_id)
return $this->get('projects/'.urlencode($project_id).'/hooks/'.urlencode($hook_id));
}

public function addHook($project_id, $url)
public function addHook($project_id, $url, $push_events = true, $issues_events = false, $merge_requests_events = false)
{
return $this->post('projects/'.urlencode($project_id).'/hooks', array(
'url' => $url
'url' => $url,
'push_events' => $push_events,
'issues_events' => $issues_events,
'merge_requests_events' => $merge_requests_events
));
}

public function updateHook($project_id, $hook_id, $url)
public function updateHook($project_id, $hook_id, $url, $push_events = null, $issues_events = null, $merge_requests_events = null)
{
return $this->put('projects/'.urlencode($project_id).'/hooks/'.urlencode($hook_id), array(
$params = array(
'url' => $url
));
);

if (null !== $push_events) {
$params['push_events'] = $push_events;
}

if (null !== $issues_events) {
$params['issues_events'] = $issues_events;
}

if (null !== $merge_requests_events) {
$params['merge_requests_events'] = $merge_requests_events;
}

return $this->put('projects/'.urlencode($project_id).'/hooks/'.urlencode($hook_id), $params);
}

public function removeHook($project_id, $hook_id)
Expand Down
8 changes: 4 additions & 4 deletions lib/Gitlab/Model/Project.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,16 @@ public function hook($hook_id)
return Hook::fromArray($this->getClient(), $data);
}

public function addHook($url)
public function addHook($url, $push_events = true, $issues_events = false, $merge_requests_events = false)
{
$data = $this->api('projects')->addHook($this->id, $url);
$data = $this->api('projects')->addHook($this->id, $url, $push_events, $issues_events, $merge_requests_events);

return Hook::fromArray($this->getClient(), $data);
}

public function updateHook($hook_id, $url)
public function updateHook($hook_id, $url, $push_events = null, $issues_events = null, $merge_requests_events = null)
{
$data = $this->api('projects')->updateHook($this->id, $hook_id, $url);
$data = $this->api('projects')->updateHook($this->id, $hook_id, $url, $push_events, $issues_events, $merge_requests_events);

return Hook::fromArray($this->getClient(), $data);
}
Expand Down