Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #7842] Rename layer to dataset #7841

Merged
merged 46 commits into from
Jul 22, 2021
Merged

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Jul 20, 2021

References: #7842

This PR is meant to introduce a big change in the code, by renaming layers to datasets.
There is still usage of the word Layer in the code (especially in the variables), but this is the first implementation.
The main changes are:

  • Renaming as much as possible of the world Layer. This includes:
    -- Models: from Layer to Dataset
    -- Foreign Key
    -- Properties: from map.layers to map.datasets
    -- Methods: from def layer_metadata to def dataset_metadata
    -- Forms: from LayerForm into DatasetForm
    -- Management commands: from set_all_datasets_public to set_all_datasets_public
    -- Tests refactor
    -- CircleCI build yml
    -- Permissions name

NOTE: the requirements.txt will be updated once the client PR is ready. Otherwise, the build (and the app) will crash
client PR: GeoNode/geonode-mapstore-client#343

The issue will be created soon

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 20, 2021
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #7841 (89e5d33) into master (3692cc5) will increase coverage by 0.00%.
The diff coverage is 63.71%.

@@           Coverage Diff           @@
##           master    #7841   +/-   ##
=======================================
  Coverage   56.62%   56.63%           
=======================================
  Files         691      698    +7     
  Lines       43565    43612   +47     
  Branches     5583     5585    +2     
=======================================
+ Hits        24670    24700   +30     
- Misses      17458    17473   +15     
- Partials     1437     1439    +2     

@giohappy giohappy changed the title Rename layer to dataset [Fixes #7842] Rename layer to dataset Jul 21, 2021
@afabiani afabiani added this to the 4.0.0 milestone Jul 21, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2021

This pull request introduces 1 alert when merging 999ba95 into 3692cc5 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2021

This pull request introduces 1 alert when merging b3dce52 into 3692cc5 - view on LGTM.com

new alerts:

  • 1 for Unused import

@afabiani afabiani merged commit b140576 into master Jul 22, 2021
@afabiani afabiani deleted the rename_layer_to_dataset branch July 22, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants