-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #7842] Rename layer to dataset #7841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into rename_layer_to_dataset
Codecov Report
@@ Coverage Diff @@
## master #7841 +/- ##
=======================================
Coverage 56.62% 56.63%
=======================================
Files 691 698 +7
Lines 43565 43612 +47
Branches 5583 5585 +2
=======================================
+ Hits 24670 24700 +30
- Misses 17458 17473 +15
- Partials 1437 1439 +2 |
This pull request introduces 1 alert when merging 999ba95 into 3692cc5 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging b3dce52 into 3692cc5 - view on LGTM.com new alerts:
|
giohappy
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #7842
This PR is meant to introduce a big change in the code, by renaming
layers
todatasets
.There is still usage of the word
Layer
in the code (especially in the variables), but this is the first implementation.The main changes are:
-- Models: from
Layer
toDataset
-- Foreign Key
-- Properties: from
map.layers
tomap.datasets
-- Methods: from
def layer_metadata
todef dataset_metadata
-- Forms: from
LayerForm
intoDatasetForm
-- Management commands: from
set_all_datasets_public
toset_all_datasets_public
-- Tests refactor
-- CircleCI build
yml
-- Permissions name
NOTE: the requirements.txt will be updated once the client PR is ready. Otherwise, the build (and the app) will crash
client PR: GeoNode/geonode-mapstore-client#343
The issue will be created soon
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.