Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GNIP-89] Remote Service ASYNC api interfaces to the Resource Manager #7829

Merged
merged 41 commits into from
Aug 4, 2021

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Jul 19, 2021

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #7829 (8a72f16) into master (d605bcd) will decrease coverage by 0.11%.
The diff coverage is 33.22%.

❗ Current head 8a72f16 differs from pull request most recent head 4fca5d7. Consider uploading reports for the commit 4fca5d7 to get more accurate results

@@            Coverage Diff             @@
##           master    #7829      +/-   ##
==========================================
- Coverage   56.65%   56.53%   -0.12%     
==========================================
  Files         704      710       +6     
  Lines       43961    44199     +238     
  Branches     5652     5682      +30     
==========================================
+ Hits        24904    24990      +86     
- Misses      17618    17769     +151     
- Partials     1439     1440       +1     

@giohappy giohappy self-requested a review July 22, 2021 08:09
Copy link
Contributor

@giohappy giohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix conflicts

@giohappy
Copy link
Contributor

giohappy commented Jul 29, 2021

@afabiani to increase API v2 consistency, and simplify its understanding and usage by any client (including GeoNode's own) I suggest to move or replicate the following endpoints under the /resources/ API:

  • 'resource-service/delete/'
  • 'resource-service/update/'
  • 'resource-service/copy/' (yet to implement)
  • 'resource-service/permissions/', either replacing or merging this with the existing get_perms and set_perms

The best would be to adopt standard HTTP methods for update (PATCH) and delete (DELETE)

afabiani added 3 commits July 29, 2021 12:01
…ng 'resource-service' endpoints to 'resources' namespace

 - Merges 'permissions' request methods under one single 'URL'
 - Implements the 'COPY' endpoint
@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2021

This pull request introduces 2 alerts when merging 1fc9b54 into c62daab - view on LGTM.com

new alerts:

  • 2 for Property in old-style class

@afabiani afabiani changed the title [WIP] Remote Service ASYNC api interfaces to the Resource Manager [GNIP-89] Remote Service ASYNC api interfaces to the Resource Manager Aug 3, 2021
@afabiani afabiani self-assigned this Aug 3, 2021
@afabiani afabiani added this to the 4.0.0 milestone Aug 3, 2021
@afabiani afabiani merged commit 8e57c3f into master Aug 4, 2021
@afabiani afabiani deleted the remote_service_api_interfaces branch August 4, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants