-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GNIP-89] Remote Service ASYNC api interfaces to the Resource Manager #7829
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7829 +/- ##
==========================================
- Coverage 56.65% 56.53% -0.12%
==========================================
Files 704 710 +6
Lines 43961 44199 +238
Branches 5652 5682 +30
==========================================
+ Hits 24904 24990 +86
- Misses 17618 17769 +151
- Partials 1439 1440 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix conflicts
…efault property values
…te_service_api_interfaces
…efault property values
…te_service_api_interfaces
… "resource_service_delete", "resource_service_update"
…te_service_api_interfaces
- Improve a bit the 'dirty' attribute by reducing the DB calls when not strictly necessary
…te_service_api_interfaces # Conflicts: # geonode/base/migrations/0060_resourcebase_state.py # geonode/upload/__init__.py # geonode/upload/tasks.py
…te_service_api_interfaces
…te_service_api_interfaces
@afabiani to increase API v2 consistency, and simplify its understanding and usage by any client (including GeoNode's own) I suggest to move or replicate the following endpoints under the /resources/ API:
The best would be to adopt standard HTTP methods for update (PATCH) and delete (DELETE) |
…ng 'resource-service' endpoints to 'resources' namespace - Merges 'permissions' request methods under one single 'URL' - Implements the 'COPY' endpoint
…te_service_api_interfaces
This pull request introduces 2 alerts when merging 1fc9b54 into c62daab - view on LGTM.com new alerts:
|
…te_service_api_interfaces
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.