Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #4521] Migrate Tests to CircleCI: smoke, apps, upload, analytics and CSW #6760

Merged
merged 14 commits into from
Dec 30, 2020

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Dec 30, 2020

Ref. : #4521 Move from Travis CI to Circle CI

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #6760 (d096bc5) into master (12d3f1e) will decrease coverage by 21.59%.
The diff coverage is 24.39%.

@@             Coverage Diff             @@
##           master    #6760       +/-   ##
===========================================
- Coverage   51.62%   30.03%   -21.60%     
===========================================
  Files         573      573               
  Lines       40764    40782       +18     
  Branches     5501     5501               
===========================================
- Hits        21045    12248     -8797     
- Misses      18385    27857     +9472     
+ Partials     1334      677      -657     

@afabiani afabiani self-assigned this Dec 30, 2020
@afabiani afabiani changed the title Migrate Tests to CircleCI: smoke, apps, upload, analytics and CSW [Fixes #4521] Migrate Tests to CircleCI: smoke, apps, upload, analytics and CSW Dec 30, 2020
@afabiani afabiani merged commit e357f55 into master Dec 30, 2020
@afabiani afabiani deleted the circle-ci-migration branch December 30, 2020 19:32
@afabiani afabiani added this to the 3.2 milestone Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant