Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12847] Stop using Gravatar service for the default gravar #12849

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

giohappy
Copy link
Contributor

@giohappy giohappy commented Jan 27, 2025

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

Sorry, something went wrong.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 27, 2025
@giohappy giohappy added this to the 5.0.0 milestone Jan 27, 2025
@giohappy giohappy linked an issue Jan 27, 2025 that may be closed by this pull request
@giohappy giohappy self-assigned this Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (58b43b0) to head (b6417d3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12849      +/-   ##
==========================================
- Coverage   67.97%   67.97%   -0.01%     
==========================================
  Files         977      977              
  Lines       59038    59040       +2     
  Branches     6897     6897              
==========================================
  Hits        40132    40132              
- Misses      17263    17266       +3     
+ Partials     1643     1642       -1     

@giohappy giohappy merged commit 5eaad8a into master Jan 27, 2025
17 checks passed
@giohappy giohappy deleted the disable_gravatar_provider branch January 27, 2025 13:12
Copy link
Contributor

The backport to 4.4.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4.x 4.4.x
# Navigate to the new working tree
cd .worktrees/backport-4.4.x
# Create a new branch
git switch --create backport-12849-to-4.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5eaad8a8f05291c1383756e64f665e608b021666
# Push it to GitHub
git push --set-upstream origin backport-12849-to-4.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4.x

Then, create a pull request where the base branch is 4.4.x and the compare/head branch is backport-12849-to-4.4.x.

giohappy added a commit that referenced this pull request Jan 27, 2025
…2849)

* disable gravatar provider

* fix hardcoded avatar urls in permspec tests

* fix hardcoded avatar urls in permspec tests (2)
giohappy added a commit that referenced this pull request Jan 27, 2025
…2849) (#12851)

* disable gravatar provider

* fix hardcoded avatar urls in permspec tests

* fix hardcoded avatar urls in permspec tests (2)
Gpetrak pushed a commit that referenced this pull request Jan 28, 2025
…2849)

* disable gravatar provider

* fix hardcoded avatar urls in permspec tests

* fix hardcoded avatar urls in permspec tests (2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.4.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using Gravatar service for the default gravar
2 participants