Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12841] Add avatar templates, changing default from django-avatar to geonode-base #12842

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

cmotadev
Copy link
Contributor

This PR is to correct a little template breaker into GeoNode. In the Profile Editor, Change Avatar, when we click on change button, it renders a simple HTML page. This page is a django-avatar default template. With some little modifications, these pages now are with geonode template and some additional links, like "go back to profile editor", "delete avatar"...

This proposal were submitted on this further request:

Actual state

Image

Proposed by the pull request

Add

Image

Edit

Image

Confirm Delete

Image

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 24, 2025
@cmotadev cmotadev changed the title [Fixes #12841 Add avatar templates, changing default from django-avatar to geonode-base [Fixes #12841] Add avatar templates, changing default from django-avatar to geonode-base Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (0258939) to head (aa4bbd8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12842       +/-   ##
===========================================
+ Coverage   55.87%   67.97%   +12.10%     
===========================================
  Files         977      977               
  Lines       59035    59038        +3     
  Branches     6897     6897               
===========================================
+ Hits        32984    40132     +7148     
+ Misses      24669    17263     -7406     
- Partials     1382     1643      +261     

@giohappy giohappy self-requested a review January 27, 2025 09:09
@giohappy giohappy added this to the 5.0.0 milestone Jan 27, 2025
@giohappy giohappy merged commit 58b43b0 into GeoNode:master Jan 27, 2025
18 checks passed
@giohappy giohappy linked an issue Jan 27, 2025 that may be closed by this pull request
giohappy added a commit that referenced this pull request Jan 27, 2025
…t from django-avatar to geonode-… (#12848)

* Add avatar templates, changing default from django-avatar to geonode-base (#12842)

* fix fomratting from previous PRs

---------

Co-authored-by: Carlos Eduardo Miranda Mota <cmota.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Avatar Forms (Profile Editor) to use GeoNode Templates
2 participants