Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12674] store spatial file is always false during cloning #12675

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

mattiagiupponi
Copy link
Contributor

ref #12674
for 44x -> GeoNode/geonode-importer#277

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi self-assigned this Oct 22, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 22, 2024
@mattiagiupponi mattiagiupponi linked an issue Oct 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.04%. Comparing base (b6a26f3) to head (8fe4ecf).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12675      +/-   ##
==========================================
+ Coverage   60.80%   67.04%   +6.23%     
==========================================
  Files         951      951              
  Lines       56909    56909              
  Branches     6719     6719              
==========================================
+ Hits        34603    38154    +3551     
+ Misses      20765    17147    -3618     
- Partials     1541     1608      +67     

@giohappy giohappy merged commit 8d58004 into master Oct 23, 2024
16 of 17 checks passed
@giohappy giohappy deleted the ISSUE_12674 branch October 23, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store spatial file is always false during cloning #276
2 participants