Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12596] User with notification disabled still receive the noti… #12597

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

mattiagiupponi
Copy link
Contributor

…fications

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi added this to the 4.4.0 milestone Sep 20, 2024
@mattiagiupponi mattiagiupponi self-assigned this Sep 20, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.26%. Comparing base (5bcbd82) to head (989079d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12597   +/-   ##
=======================================
  Coverage   64.26%   64.26%           
=======================================
  Files         888      888           
  Lines       53619    53619           
  Branches     6608     6608           
=======================================
+ Hits        34458    34459    +1     
  Misses      17646    17646           
+ Partials     1515     1514    -1     

@giohappy giohappy merged commit 3973941 into master Sep 20, 2024
18 checks passed
@giohappy giohappy deleted the ISSUE_12596 branch September 20, 2024 12:52
github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
#12597)

* [Fixes #12596] User with notification disabled still receive the notifications

* [Fixes #12596] User with notification disabled still receive the notifications

(cherry picked from commit 3973941)
mattiagiupponi added a commit that referenced this pull request Sep 20, 2024
#12597) (#12598)

* [Fixes #12596] User with notification disabled still receive the notifications

* [Fixes #12596] User with notification disabled still receive the notifications

(cherry picked from commit 3973941)

Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.4.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User with notification disabled still receive the notifications
2 participants