Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12589] Update bbox command for maps #12590

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

kikislater
Copy link
Contributor

@kikislater kikislater commented Sep 18, 2024

ref: #12589

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Sep 18, 2024
@kikislater kikislater changed the title Update bbox command for maps [Fix #12589] Update bbox command for maps Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.25%. Comparing base (5bcbd82) to head (e37db74).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12590      +/-   ##
==========================================
- Coverage   64.26%   64.25%   -0.01%     
==========================================
  Files         888      888              
  Lines       53619    53624       +5     
  Branches     6608     6609       +1     
==========================================
  Hits        34458    34458              
- Misses      17646    17651       +5     
  Partials     1515     1515              

@mattiagiupponi mattiagiupponi self-requested a review September 19, 2024 09:07
@mattiagiupponi mattiagiupponi linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link
Contributor

@mattiagiupponi mattiagiupponi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kikislater the formatting is failing,
please run black geonode && flake8 geonode and fix it accordingly.
The rest looks good

@kikislater
Copy link
Contributor Author

Done but I have made a new commit before running black.
How to run Code formatting worflow again?

@mattiagiupponi
Copy link
Contributor

Done but I have made a new commit before running black.
How to run Code formatting worflow again?

You can just push the changes and the flow will automatically run again

@kikislater
Copy link
Contributor Author

kikislater commented Sep 20, 2024

Done but I have made a new commit before running black.
How to run Code formatting worflow again?

You can just push the changes and the flow will automatically run again

It did not, as the second commit was the new push !
228baa3

@mattiagiupponi
Copy link
Contributor

mattiagiupponi commented Sep 20, 2024

It did not, as the second commit was the new push ! 228baa3

I manually run the check and is still failing. Looks like that on line 59 there are still some whitespace as you can see from this:
https://github.com/GeoNode/geonode/blob/228baa30b7a44a937f143c5a4ffecf7e481eb59e/geonode/geoserver/management/commands/sync_geonode_maps.py#L59C35-L59C46

If you select the line you will see the white spaces

@mattiagiupponi
Copy link
Contributor

mattiagiupponi commented Sep 20, 2024

Looks good @kikislater, I'll try it in the next few days and then I'll merge it.
Thanks for the contribution! :)

@mattiagiupponi mattiagiupponi merged commit 684227f into GeoNode:master Sep 23, 2024
20 of 21 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
* Update bbox command for maps

(cherry picked from commit 684227f)
mattiagiupponi pushed a commit that referenced this pull request Sep 23, 2024
* Update bbox command for maps

(cherry picked from commit 684227f)

Co-authored-by: Sylvain POULAIN <kikislater@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.4.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bbox command for maps
2 participants