-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #12589] Update bbox command for maps #12590
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12590 +/- ##
==========================================
- Coverage 64.26% 64.25% -0.01%
==========================================
Files 888 888
Lines 53619 53624 +5
Branches 6608 6609 +1
==========================================
Hits 34458 34458
- Misses 17646 17651 +5
Partials 1515 1515 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kikislater the formatting is failing,
please run black geonode && flake8 geonode
and fix it accordingly.
The rest looks good
Done but I have made a new commit before running black. |
You can just push the changes and the flow will automatically run again |
It did not, as the second commit was the new push ! |
I manually run the check and is still failing. Looks like that on line 59 there are still some whitespace as you can see from this: If you select the line you will see the white spaces |
Looks good @kikislater, I'll try it in the next few days and then I'll merge it. |
ref: #12589
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.