Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11817] Drop Nginx and Letsencrypt Dockerfiles #11818

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Conversation

giohappy
Copy link
Contributor

@giohappy giohappy commented Jan 9, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@giohappy giohappy requested a review from afabiani January 9, 2024 17:06
@giohappy giohappy self-assigned this Jan 9, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 9, 2024
@giohappy giohappy linked an issue Jan 9, 2024 that may be closed by this pull request
@giohappy giohappy marked this pull request as draft January 9, 2024 17:20
@giohappy giohappy marked this pull request as ready for review January 9, 2024 17:23
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #11818 (20656ab) into master (c1f8aad) will increase coverage by 0.00%.
Report is 13 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11818   +/-   ##
=======================================
  Coverage   62.98%   62.98%           
=======================================
  Files         876      876           
  Lines       52571    52571           
  Branches     6609     6609           
=======================================
+ Hits        33112    33114    +2     
+ Misses      17940    17937    -3     
- Partials     1519     1520    +1     

@giohappy giohappy merged commit 535f08c into master Jan 10, 2024
@giohappy giohappy deleted the issue_11817 branch January 10, 2024 08:59
github-actions bot pushed a commit that referenced this pull request Jan 10, 2024
* Drop Nginx and Letsencrypt Dockerfiles

* align compose files

* algin compose filew (2)

(cherry picked from commit 535f08c)
giohappy added a commit that referenced this pull request Jan 10, 2024
* Drop Nginx and Letsencrypt Dockerfiles

* align compose files

* algin compose filew (2)

(cherry picked from commit 535f08c)

Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.2.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop nginx and letsencrypt dockerfiles
2 participants