Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black fails on python3.10 constructs #12458

Closed
2 tasks done
etj opened this issue Jul 30, 2024 · 0 comments · Fixed by #12461
Closed
2 tasks done

black fails on python3.10 constructs #12458

etj opened this issue Jul 30, 2024 · 0 comments · Fixed by #12461
Assignees

Comments

@etj
Copy link
Contributor

etj commented Jul 30, 2024

Locally black fails on match construct, since the pyproject.toml file forces py3.7 syntax:
https://github.com/GeoNode/geonode/blob/4.3.1/pyproject.toml#L3

github workflow has been modify in order to use py310 and make the internal checks succeed:
https://github.com/GeoNode/geonode/blob/master/.github/workflows/flake8.yml#L40

  • modify pyproject.toml to make black work on py310
  • revert .github/workflows/flake8.yml to use global configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants