Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map thumbnails extent always cover the whole globe #12455

Closed
giohappy opened this issue Jul 30, 2024 · 0 comments · Fixed by #12460
Closed

Map thumbnails extent always cover the whole globe #12455

giohappy opened this issue Jul 30, 2024 · 0 comments · Fixed by #12460
Assignees
@mattiagiupponi
Labels
4.3.x master regression Issues related to regressions.

Comments

@giohappy
Copy link
Contributor

giohappy commented Jul 30, 2024 •
edited
Loading

Expected Behavior

When a map is created the thumbnail covers the area of its map layers

Actual Behavior

When a map is created the thumbnail covers the whole globe.

For the creation of the thumbnail for a map, it cycles over the maps's maplayers. I suspect that at creation time we're generating the thumbnail before the maplayers are saved to DB. In fact, if you recreate the thumbnail afterward (with the thumbnail widget), the extent is calculated correctly.

Steps to Reproduce the Problem

  1. Open a dataset that doesn't cover the whole globe
  2. Click "Create map"
  3. Save the map
  4. The thumbnail covers the whole globe
@giohappy giohappy self-assigned this Jul 30, 2024
@giohappy giohappy added regression Issues related to regressions. master 4.3.x labels Jul 30, 2024
@giohappy giohappy changed the title Map thumbnails area always cover the whole globe Map thumbnails extent always cover the whole globe Jul 30, 2024
@giohappy giohappy assigned mattiagiupponi and unassigned giohappy Jul 30, 2024
mattiagiupponi added a commit that referenced this issue Jul 30, 2024
@mattiagiupponi
[Fixes #12455] Map thumbnails extent always cover the whole globe
060b71c
@mattiagiupponi mattiagiupponi linked a pull request Jul 30, 2024 that will close this issue
[Fixes #12455] Map thumbnails extent always cover the whole globe #12460
Merged
12 tasks
mattiagiupponi added a commit that referenced this issue Jul 30, 2024
@mattiagiupponi
[Fixes #12455] Map thumbnails extent always cover the whole globe
84c7e97
mattiagiupponi added a commit that referenced this issue Jul 30, 2024
@mattiagiupponi
[Fixes #12455] Map thumbnails extent always cover the whole globe
a52900d
mattiagiupponi added a commit that referenced this issue Sep 18, 2024
@mattiagiupponi
[Fixes #12455] fix test
0819371
github-actions bot pushed a commit that referenced this issue Sep 18, 2024
@mattiagiupponi @github-actions
[Fixes #12455] Map thumbnails extent always cover the whole globe (#1…
c07e533 
…2460)

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* Fixed bbox calculation and repositioned utils

* [Fixes #12455] fix test

---------

Co-authored-by: G. Allegri <giohappy@gmail.com>
(cherry picked from commit 5bcbd82)
giohappy pushed a commit that referenced this issue Sep 18, 2024
@github-actions @mattiagiupponi
[Fixes #12455] Map thumbnails extent always cover the whole globe (#1…
482b220 
…2460) (#12588)

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* [Fixes #12455] Map thumbnails extent always cover the whole globe

* Fixed bbox calculation and repositioned utils

* [Fixes #12455] fix test

---------

Co-authored-by: G. Allegri <giohappy@gmail.com>
(cherry picked from commit 5bcbd82)

Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattiagiupponi mattiagiupponi

Labels
4.3.x master regression Issues related to regressions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fixes #12455] Map thumbnails extent always cover the whole globe GeoNode/geonode
2 participants
@giohappy @mattiagiupponi