Double input along with latin accents

[dstwwy]

Hello.

I'm using the suggested keyboard app in #431 on my main phone and the stock version of LineageOS keyboard on my secondary phone, and both are able to type accented (áèîõü) characters as explained in https://blog.rom1v.com/2018/03/introducing-scrcpy/#handle-text-input.

However, when inputing [accent] then [key], scrcpy isn't able to recognize that I want a accented character only, so áá turns into aáaá. Is it possible to filter the output when I type an accent, like by just skiping the first output?

Thanks for the project, it was a lifechanger ever since its first release.

[rom1v]

To fix #87, since v1.4, scrcpy handles letters differently than other text (411aa4f). This is the cause of this bug.

I should probably manage several "input modes" and introduce a parameter to select it, because I think there is no solution working reliably for all cases. The modes would be:

• raw key events only (ignore text events)
• text events (ignore raw key events which produce text) (this was th behavior until 1.3, the one you want)
• mixed (text events only for non-letters) (this is the current behavior, a compromise to fix Unable to use keyboard on Unreal Engine game #87 while working relatively good for text)

[dstwwy]

Started testing 1.3 and got a bunch of wildly varying results, before noticing that I was on Gboard. Thanks Google.

So far it behaves as you said on 1.3, so I'll use both according to my needs. As for your solution, it seems that every options brings issues, so I don't know if it's worth pursuing instead of waiting for a fix on how adb works (dunno if even possible) or something else.

[rom1v]

This is not a bug in adb, just a conflict between injecting text and injecting press+release events.

[dstwwy]

It's not caused by how adb works (#214)? Although you explained how you are handling accents on your blog, so you might be sidestepping this issue. If so I'll be here for tests, if needed.

[rom1v]

It's not caused by how adb works (#214)?

No. There are 2 issues:

1. Android only supports ASCII for injecting text.
2. we need different events for generating text or for pressing keys.

If you inject à, with the workaround explained in the blog post, we can inject the text correctly, so the first issue is not a problem here.

In itself, here, the second issue should not be a problem either: it is clear that we want to inject à as text.

But related to #87, when we press a letter, sometimes we want a letter (because we are typing text), sometimes we want the press+release events (typically wasd in a game). So to support this use case, all text events with letters (without accents) are ignored and raw events for letters are forwarded instead.

As a consequence, now when you press à, it generates both the "key a pressed", "key a released", and "text à".

In other words, even if issue 1 did not exist, you would still have the problem.

If so I'll be here for tests, if needed.

👍

[dstwwy]

Ah, a key up event, the game example was very clear. Now I see the problem.

[dstwwy]

Could you add your parameter suggestion on a new release, while there's no definitive solution? Doesn't look like it should break anything since the legacy code would stay inactive unless selected.

[rom1v]

Yes, I planned to add an option --text-events={all, non-alpha, none} before the v1.10 release, but I didn't had time to implement it. So I'll do it later :)

[fefo-dev]

Hi @rom1v , do you still plan to add the toggle on your next release? So far I've been using both 1.3 and 1.9 (.10 has the console issue), and I'm looking forward to it.

[rom1v]

do you still plan to add the toggle on your next release?

Yes.

For 1.11, in addition to what is already on dev, I would like to fix:

• Touch input offset on secondary monitor #15 (PR fix for resizing HIDPI MacOS windows #848)
• scrcpy-noconsole.exe shows a console #691 (no-console issue)
• this one

[rom1v]

I implemented it in textevents.

scrcpy-textevents.zip
SHA256: 0086a66ca8eac3faef21082becd696b33cd4c0e803c8acd6ba1d8ec068d8e1a9

(extract this in your scrcpy v1.10 folder to override)

Now, the text works like in v1.3:

scrcpy --prefer-text-events=always  # this is the default

To get the behavior of v1.4→v1.10:

scrcpy --prefer-text-events=non-alpha

And there is another mode, which never sends text events (probably useful only for US keyboard on both the computer and the device).

scrcpy --prefer-text-events=never