-
-
Notifications
You must be signed in to change notification settings - Fork 22.6k
SSO token caching and retrieval in CachePool #4931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This implementation improves the authentication process by securely caching SSO tokens and managing user sessions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements SSO token caching and retrieval functionality to improve authentication security by replacing direct user data transmission via URL parameters with a secure token-based approach.
- Replaces direct user data URL parameters with secure temporary tokens during SSO redirect flow
- Adds server-side caching mechanism for SSO tokens with automatic expiration (120 seconds)
- Updates client-side authentication flow to retrieve user data via API call using the temporary token
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
packages/ui/src/views/auth/ssoSuccess.jsx | Updates SSO success handling to use token-based API call instead of parsing user data from URL |
packages/ui/src/api/auth.js | Adds new API endpoint for SSO token validation and user data retrieval |
packages/server/src/enterprise/routes/auth/index.ts | Registers new SSO success route endpoint |
packages/server/src/enterprise/middleware/passport/index.ts | Generates UUID tokens and stores user data in cache during SSO redirect |
packages/server/src/enterprise/controllers/auth/index.ts | Implements SSO token validation controller with cache lookup |
packages/server/src/CachePool.ts | Adds SSO token caching methods with Redis support and 120-second expiration |
This implementation improves the authentication process by securely caching SSO tokens and managing user sessions.