Feature: Option to add apikeys to the DB instead of api.json. #2783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryHengZJ
reviewed
Jul 23, 2024
vinodkiran
commented
Jul 25, 2024
# Conflicts: # packages/server/src/controllers/chatflows/index.ts # packages/server/src/database/migrations/mariadb/index.ts # packages/server/src/database/migrations/mysql/index.ts # packages/server/src/database/migrations/postgres/index.ts # packages/server/src/database/migrations/sqlite/index.ts
HenryHengZJ
reviewed
Jul 25, 2024
packages/server/src/AppConfig.ts
Outdated
| @@ -0,0 +1,3 @@ | |||
| export const APIKEYS_STORAGE_JSON = !process.env.APIKEY_STORAGE_TYPE || process.env.APIKEY_STORAGE_TYPE === 'json' | |||
| export const APIKEYS_STORAGE_DB = | |||
| process.env.APIKEY_STORAGE_TYPE === 'db' || process.env.APIKEY_STORAGE_TYPE === 'DB' || process.env.APIKEY_STORAGE_TYPE === 'Db' | |||
There was a problem hiding this comment.
should we make this more generic?
export const appConfig = {
apiKeys: {
storageType: process.env.APIKEY_STORAGE_TYPE ? process.env.APIKEY_STORAGE_TYPE.toLowerCase() : 'json',
}
// todo: add more config options here like database, log, storage, credential and allow modification from UI
}
There was a problem hiding this comment.
Also, this new env variable needed to add at other places like start.ts, env.example, etc
There was a problem hiding this comment.
Also, this new env variable needed to add at other places like
start.ts,env.example, etc
changes pushed
There was a problem hiding this comment.
Changes pushed!!!
vinodkiran
commented
Jul 26, 2024
| } | ||
| } else { | ||
| const newKey = new ApiKey() | ||
| newKey.id = key.id |
There was a problem hiding this comment.
@HenryHengZJ I have an edge case, lets discuss!
# Conflicts: # docker/.env.example # packages/server/.env.example
HenryHengZJ
reviewed
Jul 26, 2024
CONTRIBUTING.md
Outdated
|
|
||
| | Variable | Description | Type | Default | | ||
| | ---------------------------- | ----------------------------------------------------------------------------------------------- | ------------------------------------------------ | ----------------------------------- | | ||
| | ---------------------------- | ----------------------------------------------------------------------------------------------- | ------------------------------------------------ | ----------------------------------- | --- | --- | |
There was a problem hiding this comment.
is this last few lines redundant?
There was a problem hiding this comment.
yes, and a few other lines needed fixing, pushed changes.
HenryHengZJ
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.