Skip to content

Conversation

sridhar-mani
Copy link
Collaborator

Implement a file reader for gmsh with both triangles and quad. And also change the example to use the worker script.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • examples/solidHeatTransferScript/HeatConduction2DFin/HeatConduction2DFin.html: Language not supported
Comments suppressed due to low confidence (2)

src/readers/gmshQuadReader.js:147

  • The computed edge key is not assigned to any variable before being used to update the edgeCount. Please store the result in a variable (e.g., key) to ensure the correct key is used.
edge[0] < edge[1] ? `${edge[0]}-${edge[1]}` : `${edge[1]}-${edge[0]}`;

src/readers/gmshQuadReader.js:164

  • Similar to the previous instance, the edge key is computed but not stored. Please assign the computed value to a variable (e.g., key) before using it in the condition that checks edgeCount.
edge[0] < edge[1] ? `${edge[0]}-${edge[1]}` : `${edge[1]}-${edge[0]}`;

Copy link
Member

@nikoscham nikoscham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on importing gmsh meshes. Still some tests to do, but this seems to be a great enhancement.

@nikoscham nikoscham merged commit 8f071c3 into main Apr 8, 2025
@sridhar-mani
Copy link
Collaborator Author

Yeah much things to add still but its a base. I dont know about the iterative solver much but i think that is needed because this takes too much time. If you could give some advice on where to start i could help. webgpu integration is also in parallel.

@nikoscham nikoscham linked an issue Oct 7, 2025 that may be closed by this pull request
6 tasks
@nikoscham nikoscham added the enhancement New feature or request label Oct 7, 2025
@nikoscham nikoscham self-assigned this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development of an MSH import tool
3 participants