Fix: color changing logic for LightRays Background #564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hexToRgb constant expects exactly 6 hex digits and when passed by an 8-digit string, it does not match and the function returns [1,1,1] which is white. Also, some WebGL/ogl code prefers typed arrays for uniform vectors, so it's safer to set uniform values as Float32Array. I replaced your hexToRgb with this function that supports #RGB, #RRGGBB, #RRGGBBAA. I find this minor bug when I'm making my portfolio website and I like to thank you for having this open source codes.