Skip to content

Conversation

@SergeDeGuzman
Copy link

The hexToRgb constant expects exactly 6 hex digits and when passed by an 8-digit string, it does not match and the function returns [1,1,1] which is white. Also, some WebGL/ogl code prefers typed arrays for uniform vectors, so it's safer to set uniform values as Float32Array. I replaced your hexToRgb with this function that supports #RGB, #RRGGBB, #RRGGBBAA. I find this minor bug when I'm making my portfolio website and I like to thank you for having this open source codes.

@DavidHDev
Copy link
Owner

Any component code change should be added to all 4 variants, meaning 4 files changed in this PR.

Please read CONTRIBUTING.md

@SergeDeGuzman
Copy link
Author

I only changed a constant in content/Backgrounds/LightRays/LightRays.jsx

@DavidHDev
Copy link
Owner

@SergeDeGuzman this component lives under 3 other files as well, they all need to be kept in sync.

@DavidHDev DavidHDev closed this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants