Update eslint dependencies to match zeal config #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to pin the versions to match eslint-config-zeal otherwise the new rules implemented in our config are not recognized by the eslint version used by react-scripts and throws an error.
randycoulman
approved these changes
Apr 25, 2018
| "eslint": "4.10.0", | ||
| "eslint-config-prettier": "^2.3.0", | ||
| "eslint": "4.19.0", | ||
| "eslint-config-prettier": "^2.9.0", |
There was a problem hiding this comment.
Should we take the ^ off of this one too?
There was a problem hiding this comment.
I left these matching what we were doing in our config.
| "eslint-plugin-import": "2.8.0", | ||
| "eslint-plugin-jest": "20.0.3", | ||
| "eslint-plugin-import": "2.9.0", | ||
| "eslint-plugin-jest": "21.15.0", |
There was a problem hiding this comment.
Do we need to upgrade jest* as well, or does this work without doing that?
There was a problem hiding this comment.
It works, but I'll update it for good measure. No harm there.
There was a problem hiding this comment.
On second thought I think I am going to break that out into another chore. There are probably more dependencies we might want to update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pin the versions to match eslint-config-zeal otherwise the
new rules implemented in our config are not recognized by the eslint
version used by react-scripts and throws an error.