Update to v1.1.4 #31

frank-west-iii · 2018-04-23T23:27:19Z

Updates to v1.1.4
Updates eslint-config-zeal to v1.5.0
Adds back in publicPath override in webpack dev

* extra watch options regex to react-dev-utils * fix regex * add test * fix eslint error * include react-dev-utils test in CI script * attempt to fix import error * attempt to fix error on CI * Update .eslintrc

* one-line waiting for app start * remove fixed todo

* improve eject message * cross os implementation

* add —use-npm flag to bypass yarn * add e2e test for —use-npm flag

* docs: adding section about debugging tests * docs: removing node-inspector references * docs: replacing terminal command with npm script * Update README.md

Fix another dead link

…ebook#3455)

This fixes the broken link to removed `href-no-hash.md` file, that is no longer available in the [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) plugin (since [6.0.0](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/a14617528cda23c6c88902ace1d083e4e13ac271/CHANGELOG.md))

…acebook#3537)

the code got updated from `detect()` to `choosePort` while the comment did not.

Replaced `it's` with `its`

The launch configuration code provided is not compatible with VSCode since version 1.19. The proposed documentation change is based on the response by a VSCode team member. References: facebook#3602 (comment) microsoft/vscode#40293 (comment)

* use safer/more aesthetic syntax * fix typo

Replace `provide a lot value` with `provide a lot of value`.

* Fix path regex match bug * Use the escape-string-regexp package to escape regex characters * Remove redundant character escape from path * Add removed escape of backslashes

Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command.

…in a $. (facebook#4000)

)" This reverts commit bab2c29. I meant to apply it to `next` instead.

- create-react-app@1.5.2 - react-scripts@1.1.1

Support for .mjs files added in facebook#3239 did not account for npm libraries which ship native mjs files alongside js files. This accounts for this by ensuring .js files resolve before their accompanying .mjs file. Note that this is not an ideal end state since selecting a .mjs over a .js extension should be the result of whether `import` was used instead of `require()` in a node environment with native ESM support (currently via `--experimental-modules`). Instead, this change just *always* selects a .js extension before the .mjs extension if it exists. This unbreaks support for using GraphQL (relay, apollo, etc) within create-react-app projects.

Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages

- react-scripts@1.1.2

- react-scripts@1.1.3

- react-dev-utils@5.0.1 - react-scripts@1.1.4

This was accidentally removed in the last merge.

n8io

Thanks @frank-west-iii LGTM

randycoulman

A few things to check:

Have there been any updates to Cannot import external CSS files after upgrading to react-scripts 1.0.8 facebook/create-react-app#2677 that we need to pull in?
Looking at this diff: facebook/create-react-app@v1.1.4...CodingZeal:chores/cra-1.1.4, there seems to be some spurious formatting changes. Do we need to eliminate those to keep clean diffs going forward?
A note about requiring ./polyfills.

Other than these, LGTM!

randycoulman · 2018-04-23T23:38:08Z

packages/react-scripts/config/webpack.config.dev.js

@@ -296,10 +297,10 @@ module.exports = {
          // that fall through the other loaders.
          {
            // Exclude `js` files to keep "css" loader working as it injects
-            // it's runtime that would otherwise processed through "file" loader.
+            // its runtime that would otherwise processed through "file" loader.


Wayyyy above here on L98-99, there's a require of ./polyfills that looks like it's only in our fork. Is this something that we added, or is it something they removed a while back that we missed? If the former, we should add a ZEAL comment; if the latter, we should probably also remove it.

It's still there, just out of view for the comparison. It's their's

facebook/create-react-app@v1.1.4...CodingZeal:chores/cra-1.1.4#diff-a7f98c18479be87c9f33e7604dbd1a09L45

So it is. Should we move ours up to the same place as theirs to avoid this showing as a weird diff?

Actually it is duplicated now that I look closer so I have removed it.

xjlim and others added 30 commits November 3, 2017 22:23

Refactor extra watch options regex to react-dev-utils (facebook#3362)

36cd35d

* extra watch options regex to react-dev-utils * fix regex * add test * fix eslint error * include react-dev-utils test in CI script * attempt to fix import error * attempt to fix error on CI * Update .eslintrc

one-line waiting for app start (facebook#3411)

231873e

* one-line waiting for app start * remove fixed todo

Export dismissRuntimeErrors function (facebook#3414)

5b4ff56

Improve eject message (facebook#3416)

4bec877

* improve eject message * cross os implementation

add —use-npm flag to bypass yarn (facebook#3409)

756a9a0

* add —use-npm flag to bypass yarn * add e2e test for —use-npm flag

Explain how to debug tests (facebook#2992)

b555192

* docs: adding section about debugging tests * docs: removing node-inspector references * docs: replacing terminal command with npm script * Update README.md

Fix dead link (facebook#3453)

801fec2

Fix another dead link

Add a localhost-only log message pointing folks to the PWA docs. (fac…

daf8df1

…ebook#3455)

Fix misspelling (facebook#3468)

657d145

Fix run-time error unregistering (facebook#3474)

c789794

Update Prettier editor integration link (facebook#3503)

032e621

Add link to nvm-windows (facebook#3489)

733ba3a

Update User Guide with deploying to GitHub User pages (facebook#3510)

770fdf4

Unmount the App in the default test (facebook#3511)

9af0422

Add mjs and jsx filename extensions to file-loader exclude pattern (f…

af291f3

…acebook#3537)

Updates comment to reflect codebase (facebook#3576)

a1c5b8f

the code got updated from `detect()` to `choosePort` while the comment did not.

Fixed typo in webpack.config.dev.js (facebook#3601)

bd682de

Replaced `it's` with `its`

Use friendlier syntax for setting env var on Windows (facebook#3533)

76e3165

* use safer/more aesthetic syntax * fix typo

Update README.md (facebook#3645)

5d7845a

Fix typo in the User Guide (facebook#3670)

12120f6

Replace `provide a lot value` with `provide a lot of value`.

Fix path regex match bug (facebook#3686)

8cae659

* Fix path regex match bug * Use the escape-string-regexp package to escape regex characters * Remove redundant character escape from path * Add removed escape of backslashes

Document adding a router (facebook#3709)

bb71830

Link to an explanation for forking react-scripts (facebook#3710)

ece9523

Add a section on supported browsers

1c9301a

Link to a new user guide section

1908dd1

Link to section about routing

f175c90

Link to React docs

5537126

Fix the router doc

4f0cdcf

robinvdvleuten and others added 21 commits January 20, 2018 19:31

Set the public path to the asset manifest entries (facebook#2544)

bab2c29

Include {json,css} files in prettier command (facebook#3894)

eee2907

Update User Guide's README.md to include `json` and `css` files in the command to format the entire project for the first time with prettier, that it's consistent with the `lint-staged` command.

Update instructions for continuous delivery with Netlify (facebook#3971)

815853d

Update dotenv-expand to fix bug with environment variables that conta…

32ea0c0

…in a $. (facebook#4000)

Unpin and bump fsevents (for 1.x branch) (facebook#4006)

09d216e

Add 1.1.1 changelog

984d661

Revert "Set the public path to the asset manifest entries (facebook#2544

1a9722f

)" This reverts commit bab2c29. I meant to apply it to `next` instead.

Publish

0b1d636

- create-react-app@1.5.2 - react-scripts@1.1.1

Add troubleshooting for Github Pages (facebook#4197)

cb1608b

Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages

Add 1.1.2 changelog (facebook#4242)

780a457

Publish

609aeea

- react-scripts@1.1.2

Work around Jest environment resolving bug (facebook#4247)

d639e90

Changelog for 1.1.3

f040d85

Publish

408db51

- react-scripts@1.1.3

Update detect-port-alt (facebook#4250)

110fded

Changelog for 1.1.4

305bd70

Publish

dfbc71c

- react-dev-utils@5.0.1 - react-scripts@1.1.4

Add back in publicPath override in webpack dev

c569c36

This was accidentally removed in the last merge.

Merge tag 'v1.1.4' into chores/cra-1.1.4

7facd46

Update eslint-config-zeal

c5e5f11

frank-west-iii requested review from randycoulman and n8io April 23, 2018 23:27

n8io reviewed Apr 23, 2018

View reviewed changes

randycoulman reviewed Apr 23, 2018

View reviewed changes

Pull in formatted code from upstream

8705835

frank-west-iii force-pushed the chores/cra-1.1.4 branch from d260c4f to 8705835 Compare April 24, 2018 15:58

Remove duplicate polyfill require

ff0bebd

frank-west-iii merged commit a10af3e into zeal Apr 24, 2018

frank-west-iii deleted the chores/cra-1.1.4 branch April 24, 2018 16:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to v1.1.4 #31

Update to v1.1.4 #31

frank-west-iii commented Apr 23, 2018

n8io left a comment

randycoulman left a comment

randycoulman Apr 23, 2018

frank-west-iii Apr 24, 2018

randycoulman Apr 24, 2018

frank-west-iii Apr 24, 2018

Update to v1.1.4 #31

Update to v1.1.4 #31

Conversation

frank-west-iii commented Apr 23, 2018

n8io left a comment

Choose a reason for hiding this comment

randycoulman left a comment

Choose a reason for hiding this comment

randycoulman Apr 23, 2018

Choose a reason for hiding this comment

frank-west-iii Apr 24, 2018

Choose a reason for hiding this comment

randycoulman Apr 24, 2018

Choose a reason for hiding this comment

frank-west-iii Apr 24, 2018

Choose a reason for hiding this comment