Added test code + fetch route #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathisve
added
documentation
There was a problem hiding this comment.
@Mathisco-01, overall good work. Only a couple of minor things that need to be reviewed.
Both the "TEST_INTERVAL" and "PORT" constants are not being used throughout the source code.
Outside of this PR, we should consider replacing the occurrences of "localhost" with a constant placeholder to facilitate distributing this application in a cloud environment.
api/src/bump_test.go
Outdated
| "guildId": guildId, | ||
| }) | ||
|
|
||
| resp, _ := http.Post("http://localhost:8080/V1/bump", "application/json", bytes.NewBuffer(reqBody)) |
There was a problem hiding this comment.
See previous comment.
api/src/main.go
Outdated
| const ( | ||
| PORT = ":8080" | ||
| BUMP_INTERVAL = 60 // 1 minute in seconds | ||
| TEST_INTERVAL = 2 |
There was a problem hiding this comment.
This constant has not been implemented/used.
|
I almost forgot to mention but I added documentation for the fetch route. |
Travis-Owens
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some questionable (but working) test code.
You can run it by doing
go test.Also added the
/V1/fetchroute to get the latest 10 bumped servers.