Skip to content

Updated acoording to reviewers' requests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

Updated acoording to reviewers' requests #2

merged 1 commit into from
Oct 5, 2020

Conversation

mathisve
Copy link
Contributor

@mathisve mathisve commented Oct 4, 2020

  • Changed to a more descriptive api response
  • Changed guildId input to int from string
  • Added more documentation
  • Fixed indentation
  • Cleaned and refactored code

@mathisve mathisve requested a review from Travis-Owens October 4, 2020 17:42
@mathisve mathisve added hacktoberfest documentation Improvements or additions to documentation enhancement New feature or request labels Oct 4, 2020
Travis-Owens
Travis-Owens approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@Travis-Owens Travis-Owens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mathisco-01, Overall this is a great improvement. Breaking down the functions into multiple files will greatly improve modularity and extensibility moving forward. We're still lacking on the documentation side of things, perhaps someone is interested in that aspect of the project?

@Coding-Web-Discord Coding-Web-Discord merged commit 6191cc2 into development Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Travis-Owens Travis-Owens Travis-Owens approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mathisve @Travis-Owens @Coding-Web-Discord