Indent Options and Clarify Tab Width #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables configuration of the behavior when the tab key is pressed. Previously all tabs were converted to spaces and inserted
tabWidth
spaces in place of the tab character. This PR clarifies that thetabWidth
parameter should be used for the visual width of tabs, and adds anindentOption
parameter that specifies how to handle inserting tab characters.Adds an
IndentOption
enum with two cases for this behavior:spaces(count: Int)
tab
If
spaces(count: Int)
is specified, the editor will insert the given number of spaces when the tab key is pressed, otherwise the tab character will be kept.Related Issues
Checklist
Screenshots
tab.mov