Skip to content

✨ Padding to the left of line numbers #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
austincondiff opened this issue Mar 7, 2023 · 1 comment · Fixed by #163
Closed

✨ Padding to the left of line numbers #156

austincondiff opened this issue Mar 7, 2023 · 1 comment · Fixed by #163
Assignees
@Eliulm
Labels
enhancement New feature or request

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Mar 7, 2023 •
edited
Loading

Description

There should be 20 pixels of padding to the left of the line numbers in the ruler. This gives the line numbers a little breathing room so it is not right on the edge of the editor view.
@austincondiff austincondiff added the enhancement New feature or request label Mar 7, 2023
@Eliulm Eliulm mentioned this issue Mar 16, 2023
Merged
6 tasks
@austincondiff austincondiff moved this from 🆕 New to 🏃‍♂️ In Progress in CodeEdit Project Mar 16, 2023
@Eliulm
Copy link
Contributor

Eliulm commented Mar 16, 2023

I would like to work on this :)

thecoolwinter pushed a commit that referenced this issue Mar 16, 2023
@Eliulm
Make ruler look more like Xcode. (#163)
4ff2df5 
<!--- IMPORTANT: If this PR addresses multiple unrelated issues, it will
be closed until separated. -->

### Description

1. Add 20 pixels of inset to the left of the ruler and 8 pixels of inset
to the right of the ruler. I tried to match it as close as possible to
Xcode.
2. Set the background color of the highlight ruler line to the same
color as the highlighted line in the textView.

### Related Issues

<!--- REQUIRED: Tag all related issues (e.g. * #123) -->
<!--- If this PR resolves the issue please specify (e.g. * closes #123)
-->
<!--- If this PR addresses multiple issues, these issues must be related
to one other -->

* closes #156
* closes #128

### Checklist

<!--- Add things that are not yet implemented above -->

- [x] I read and understood the [contributing
guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)
as well as the [code of
conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots

<!--- REQUIRED: if issue is UI related -->

<img width="765" alt="Screenshot 2023-03-16 at 19 05 59"
src="https://user-images.githubusercontent.com/82230675/225717006-40530a7b-7864-404b-8d14-5307f6f83bdb.png">


<!--- IMPORTANT: Fill out all required fields. Otherwise we might close
this PR temporarily -->
@github-project-automation github-project-automation bot moved this from 🏃‍♂️ In Progress to 🏁 Complete in CodeEdit Project Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eliulm Eliulm

Labels
enhancement New feature or request
Projects
CodeEdit Project
Status: 🏁 Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make ruler look more like Xcode.
2 participants
@austincondiff @Eliulm