remove build status #56
Conversation
Speculation: It seems recently that github has been rate limiting requests to github.com workflow badge svg files from non-github.com URLs. Sadly, this seems to include github.io pages, too, which smells like an oversight to me. What this means in practice is that our homepage looks like hot dogshit full of broken links vs the github page. Compare https://clangbuiltlinux.github.io/ vs https://github.com/ClangBuiltLinux/continuous-integration2/#readme The latter is much better looking (no broken embedded images) than the former (many broken embedded images). It's sad that this is necessary, but I think it will help the home page look more professional. It will also be one less thing to update when we update the matrix using markdown-badges.py. Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
nickdesaulniers
requested review from
JustinStitt,
bwendling,
isanbard,
kees and
nathanchance
|
Can you upload an artifact of what you're seeing, @nickdesaulniers ? I see a pleasant home page on my end.
Granted, I don't check the home page very often -- Are you seeing problems only every once in awhile? |
|
|
nathanchance
left a comment
nathanchance
left a comment
There was a problem hiding this comment.
Unfortunate :( Should we still have some sort of callout, maybe something to the effect of "If you want to see the latest build status, go to the README of our continuous-integration2 repository"? Regardless, this is obviously an improvement over the status quo so merge away.
|
|
||
| - [Official Kernel Docs](https://www.kernel.org/doc/html/latest/kbuild/llvm.html) | ||
| - [Issue tracker](https://github.com/ClangBuiltLinux/linux/issues) | ||
| - [Build Status](https://github.com/ClangBuiltLinux/continuous-integration2/#readme) |
There was a problem hiding this comment.
note: we still retain a link, so "remove build status" is not accurate. More like "replace build status image grid in favor of link"
|
I can't get the broken page to appear even with lots of refreshes and private tabs + clearing cache. If this is an issue for others though then this change is good. |
|
gah, the github.com page cuts off the content and is very difficult to scroll!
|
|
Are there any large github projects with similar matrices that we can steal the formatting from? I really like: https://linux.kernelci.org/job/ (not github though) |
|
I have filed a bug against github support: https://support.github.com/ticket/personal/0/2313412 (probably not publicly accessible). |
|
Is this at all related to whatever the heck a webhook is: https://www.githubstatus.com/incidents/f7lz4nc72bvp |
|
Unfortunately, I think this is the right solution until github fixes their ACLs. I wonder if I could host something to cache the results? I could put it somewhere on .outflux.net .... |
I wonder if we can show some aggregate statistic like "Passing Builds 24/36" or something like that -- then also provide a link to the readme matrix. I propose this aggregate statistic could be generated through a workflow itself, then the main githubio page needs to just make a single call to this single badge. |
|
Just as a data point, I see the same problem in Safari: 
|
Was that on clangbuiltlinux.github.io, or https://github.com/ClangBuiltLinux/continuous-integration2#readme ? |
clangbuiltlinux.github.io, continuous-integration2's has always worked for me. |
Maybe worth researching shields.io. https://github.com/badges/shields |
oh, I did receive a response back on aug 30:
|
|
Closing this as it was fixed by @kees ' efforts here: ClangBuiltLinux/continuous-integration2#678 |
Speculation:
It seems recently that github has been rate limiting requests to github.com workflow badge svg files from non-github.com URLs.
Sadly, this seems to include github.io pages, too, which smells like an oversight to me.
What this means in practice is that our homepage looks like hot dogshit full of broken links vs the github page.
Compare
https://clangbuiltlinux.github.io/
vs
https://github.com/ClangBuiltLinux/continuous-integration2/#readme
The latter is much better looking (no broken embedded images) than the former (many broken embedded images).
It's sad that this is necessary, but I think it will help the home page look more professional. It will also be one less thing to update when we update the matrix using markdown-badges.py.