Skip to content

Conversation

martinalbert
Copy link
Contributor

npm-check-updates output:

 @testing-library/jest-dom    ^5.16.2  →  ^5.16.5
 @testing-library/react       ^12.1.2  →  ^13.4.0
 @testing-library/user-event  ^13.5.0  →  ^14.4.3
 buttercms                     ^1.2.8  →   ^1.2.9
 dotenv                       ^16.0.0  →  ^16.0.3
 react                        ^17.0.2  →  ^18.2.0
 react-dom                    ^17.0.2  →  ^18.2.0
 react-helmet-async            ^1.2.3  →   ^1.3.0
 react-router-dom              ^6.2.1  →   ^6.7.0
 react-scripts                  5.0.0  →    5.0.1

Major changes

  • @testing-library/react - drops support for React 17 and earlier (link)
  • @testing-library/user-event - lots of api changes (link)
  • react & react-dom - ReactDom.render() deprecated and more

npm audit

  • on main branch found 49 vulnerabilities (1 low, 1 moderate, 31 high, 16 critical)
  • after npm audit fix found 14 vulnerabilities (10 high, 4 critical) in 1452 scanned packages
  • after update of dependencies listed above found 1 high severity vulnerability
    • Inefficient Regular Expression Complexity in nth-check
    • path: react-scripts → @svgr/webpack → @svgr/plugin-svgo → svgo → css-select → nth-check
    • more info here

Implications

  • React.render() is used in the application therefore it will run in react 17 mode.

@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-starter-buttercms ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 5:47PM (UTC)

@martinalbert martinalbert marked this pull request as ready for review January 26, 2023 17:21
@ViolanteCodes
Copy link
Collaborator

@prokopsimek I think this looks okay - I ran a fresh install and poked around and everything looks like it is functionally the same to me. I am good to merge, but I notice your review was also requested - will you also be reviewing these PRs?

Copy link
Collaborator

@ViolanteCodes ViolanteCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@ViolanteCodes ViolanteCodes self-assigned this Jan 27, 2023
@ViolanteCodes ViolanteCodes merged commit 9d2e5ce into main Feb 3, 2023
@ViolanteCodes ViolanteCodes deleted the chore/update-dependencies branch February 3, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants