Skip to content

Conversation

prokopsimek
Copy link
Contributor

fixes #12

@prokopsimek prokopsimek self-assigned this Mar 7, 2022
@vercel
Copy link

vercel bot commented Mar 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/buttercms/react-starter-buttercms/CgoZjaodxd6oU1HFZ9Y9aBsFEMbc
✅ Preview: https://react-starter-buttercms-git-hotfix-console-err-931fab-buttercms.vercel.app

@prokopsimek prokopsimek marked this pull request as ready for review March 7, 2022 20:05
@prokopsimek
Copy link
Contributor Author

prokopsimek commented Mar 7, 2022

@ViolanteCodes

  • fixed the UNSAFE component error
  • I tried to fix the frame-ancestors error in the console but I am not sure if the preview mode will work via the iframe in ButterCMS - there is some issue that the CSP 'frame-ancestors' can't be used in meta tag but only set as a request header but in this case of the client-side app I'd have to probably add webpack or any backend server to add the header. (https://content-security-policy.com/frame-ancestors/) I removed the invalid meta tag in the head, we'll see if it helps and still works.
    • works fine for me, please re-test it from your side

@ViolanteCodes
Copy link
Collaborator

rebased on top of current main + force pushed

@ViolanteCodes ViolanteCodes merged commit 77f46b3 into main Mar 8, 2022
@ViolanteCodes ViolanteCodes deleted the hotfix/console-errors-cleanup branch March 8, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main page shows warnings in console
2 participants