Address issues from the first revision of the app #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of one per line
…va command, minor cosmetic changes
…it as arguments instead
|
@HonzaStefanik quick question: in app.json there's a duplicate description field for the JAVA_BUTTER_CMS_API_KEY - i'm assuming it's okay for me to delete one of these? |
|
Yes, I must've forgotten to delete one after rewriting the description |
|
@HonzaStefanik Still not seeing the menus working: video. Other than that, the other issues look fixed, so I've closed them :) |
ViolanteCodes
requested changes
Jun 20, 2022
…lay query parameters in search result URL
|
@HonzaStefanik Unfortunately, it looks like the "two-column-with-image" components are not rendering at all now: video |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All issues should be addressed in appropriately named commits.
This one might need additional changes based on the requirements